Re: [PATCH v6 09/10] power: supply: Support ROHM bd99954 charger

[Vaittinen, Matti]

Thanks for the patience Andy,

On Wed, 2020-03-25 at 15:21 +0200, andriy.shevchenko@xxxxxxxxxxxxxxx
wrote:
> On Wed, Mar 25, 2020 at 03:20:33PM +0200, 
> andriy.shevchenko@xxxxxxxxxxxxxxx wrote:
> > On Wed, Mar 25, 2020 at 01:00:21PM +0000, Vaittinen, Matti wrote:
> > But why?
> > 
> > You really uglify the code with ifdeffery, make a dependency to OF
> > (yes, you
> > will have to have of.h include) only because of that silly
> > macro and save 64 bytes of memory footprint.
> 
> And on top of that for !OF configuration you prevent your driver to
> be usable.
> (Consider PRP0001 ACPI case, for example)
> 

And here I revealed my ignorance what comes to ACPI world :) I didn't
know there is a way to utilize DT compatibles from ACPI.

Another mistake I did was assuming that the of_device_id would reside
in of.h. Thanks for the guidance - I do agree with you. I'll drop both
the ifdef and of_match_ptr().

Br,
	Matti