Re: [PATCH 2/3] kselftest: Extend vDSO selftest

[Vincenzo Frascino]

Hi Andy,

On 3/24/20 5:22 PM, Andy Lutomirski wrote:
> On Tue, Mar 24, 2020 at 7:51 AM Vincenzo Frascino
> <vincenzo.frascino@xxxxxxx> wrote:
>>
>> The current version of the multiarch vDSO selftest verifies only
>> gettimeofday.
>>
>> Extend the vDSO selftest to the other library functions:
>>  - time
>>  - clock_getres
>>  - clock_gettime
>>
>> The extension has been used to verify the unified vdso library on the
>> supported architectures.
> 
> The code in tools/testing/selftests/x86/test_vdso.c actually checks
> that the times returned by the vDSO are correct.  Perhaps that code
> should be copied or moved here?
> 

Good point. I was not aware of such a test. I will definitely move it here and
make sure it works for non x86 platforms as well in the next iteration of this
series.

-- 
Regards,
Vincenzo