Re: [PATCH v4 15/27] ata: let compiler optimize out ata_eh_set_lpm() on non-SATA hosts

From: Christoph Hellwig
Date: Thu Mar 26 2020 - 05:50:43 EST


On Tue, Mar 17, 2020 at 03:43:21PM +0100, Bartlomiej Zolnierkiewicz wrote:
> Add !IS_ENABLED(CONFIG_SATA_HOST) to ata_eh_set_lpm() to allow
> compiler to optimize out the function for non-SATA configs (for
> PATA hosts "ap && !ap->ops->set_lpm" condition is always true so
> it's sufficient for the function to return zero).

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>