Re: [PATCH v4 16/27] ata: start separating SATA specific code from libata-core.c

[Christoph Hellwig]

On Tue, Mar 17, 2020 at 03:43:22PM +0100, Bartlomiej Zolnierkiewicz wrote:
> Start separating SATA specific code from libata-core.c:
> 
> * move following functions to libata-sata.c:
>   - ata_tf_to_fis()
>   - ata_tf_from_fis()
>   - sata_link_scr_lpm()
>   - ata_slave_link_init()
>   - sata_lpm_ignore_phy_events()
> 
> * group above functions together in <linux/libata.h>
> 
> * include libata-sata.c in the build when CONFIG_SATA_HOST=y

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>