RE: [EXT] Re: [net-next,v1] net: mscc: ocelot: add action of police on vcap_is2

[Xiaoliang Yang]

Hi Vladimir,

Thanks, you are right, the patch need to change rule->pol to tmp->pol. I have seen your patch series, it's better to add this patch to your patch series.

Regards,
Xiaoliang Yang

-----Original Message-----
From: Vladimir Oltean <olteanv@xxxxxxxxx> 
Sent: 2020å3æ29æ 8:55
To: Xiaoliang Yang <xiaoliang.yang_1@xxxxxxx>
Cc: David S. Miller <davem@xxxxxxxxxxxxx>; netdev <netdev@xxxxxxxxxxxxxxx>; lkml <linux-kernel@xxxxxxxxxxxxxxx>; Ivan Khoronzhuk <ivan.khoronzhuk@xxxxxxxxxx>; Horatiu Vultur <horatiu.vultur@xxxxxxxxxxxxx>; Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>; Andrew Lunn <andrew@xxxxxxx>; Allan W. Nielsen <allan.nielsen@xxxxxxxxxxxxx>; Vivien Didelot <vivien.didelot@xxxxxxxxx>; Joergen Andreasen <joergen.andreasen@xxxxxxxxxxxxx>; Microchip Linux Driver Support <UNGLinuxDriver@xxxxxxxxxxxxx>; Y.b. Lu <yangbo.lu@xxxxxxx>; Alexandru Marginean <alexandru.marginean@xxxxxxx>; Po Liu <po.liu@xxxxxxx>; Claudiu Manoil <claudiu.manoil@xxxxxxx>; Vladimir Oltean <vladimir.oltean@xxxxxxx>; Leo Li <leoyang.li@xxxxxxx>; Florian Fainelli <f.fainelli@xxxxxxxxx>
Subject: [EXT] Re: [net-next,v1] net: mscc: ocelot: add action of police on vcap_is2

Caution: EXT Email

On Sat, 28 Mar 2020 at 15:50, Vladimir Oltean <olteanv@xxxxxxxxx> wrote:
>
> Hi Xiaoliang,
>
> Thanks for the patch. I've tested it, but sadly, as-is it doesn't compile.
> But then again, net-next doesn't compile either, so there...
>
> On Sat, 28 Mar 2020 at 14:41, Xiaoliang Yang <xiaoliang.yang_1@xxxxxxx> wrote:
> >
> > Ocelot has 384 policers that can be allocated to ingress ports, QoS 
> > classes per port, and VCAP IS2 entries. ocelot_police.c supports to 
> > set policers which can be allocated to police action of VCAP IS2. We 
> > allocate policers from maximum pol_id, and decrease the pol_id when 
> > add a new vcap_is2 entry which is police action.
> >
> > Signed-off-by: Xiaoliang Yang <xiaoliang.yang_1@xxxxxxx>
> > ---
[snip]
>
> For what it's worth, I am preparing another patch series for port 
> policers in DSA, and I'm keeping your patch in my tree and rebasing on 
> top of it. Depending on how things go with review, do you mind if I 
> just take your patch to address other received feedback, and repost 
> your flow-based policers together with my port-based policers?
>
> Regards,
> -Vladimir

I took the liberty to repost your patch with the compilation error fixed, as part of this series:
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.ozlabs.org%2Fpatch%2F1263358%2F&amp;data=02%7C01%7Cxiaoliang.yang_1%40nxp.com%7Cb9d56ee5885d4eb41ef708d7d37bce6b%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637210401032321171&amp;sdata=aXfztjxAHg0JJwieZQSmSNe5tYftJyVYS5MMy66awUU%3D&amp;reserved=0

So this patch is now superseded.

Thanks,
-Vladimir