Re: [net-next,v1] net: mscc: ocelot: add action of police on vcap_is2
From: Vladimir Oltean
Date: Sat Mar 28 2020 - 20:55:04 EST
On Sat, 28 Mar 2020 at 15:50, Vladimir Oltean <olteanv@xxxxxxxxx> wrote:
>
> Hi Xiaoliang,
>
> Thanks for the patch. I've tested it, but sadly, as-is it doesn't compile.
> But then again, net-next doesn't compile either, so there...
>
> On Sat, 28 Mar 2020 at 14:41, Xiaoliang Yang <xiaoliang.yang_1@xxxxxxx> wrote:
> >
> > Ocelot has 384 policers that can be allocated to ingress ports,
> > QoS classes per port, and VCAP IS2 entries. ocelot_police.c
> > supports to set policers which can be allocated to police action
> > of VCAP IS2. We allocate policers from maximum pol_id, and
> > decrease the pol_id when add a new vcap_is2 entry which is
> > police action.
> >
> > Signed-off-by: Xiaoliang Yang <xiaoliang.yang_1@xxxxxxx>
> > ---
[snip]
>
> For what it's worth, I am preparing another patch series for port
> policers in DSA, and I'm keeping your patch in my tree and rebasing on
> top of it. Depending on how things go with review, do you mind if I
> just take your patch to address other received feedback, and repost
> your flow-based policers together with my port-based policers?
>
> Regards,
> -Vladimir
I took the liberty to repost your patch with the compilation error
fixed, as part of this series:
https://patchwork.ozlabs.org/patch/1263358/
So this patch is now superseded.
Thanks,
-Vladimir