Re: [PATCH] sysfs: Remove page boundary align limitation on sysfs_emit and sysfs_emit_at

From: Greg Kroah-Hartman
Date: Wed Sep 08 2021 - 09:04:24 EST


A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top


On Wed, Sep 08, 2021 at 12:52:43PM +0000, Yu, Lang wrote:
> [AMD Official Use Only]
>
> Thanks for your reply.
> Just curious if we don't put such a limitation, what are the consequences?
> If we remove the limitation, sys_emit/sys_emit_at api will be more flexible.
> Since the comments of sysfs_emit/ sys_emit_at api are
> " sysfs_emit - scnprintf equivalent, aware of PAGE_SIZE buffer. ",
> Why not make them more equivalent with scnprintf?

Because this is not a general replacement for scnprintf(), it is only to
be used with sysfs files.

Where else are you wanting to use these functions that this patch woulud
be required that does not haver to deal with sysfs?

thanks,

greg k-h