Re: [PATCH] ASoC: dt-bindings: lpass: add binding headers for digital codecs

[Srinivasa Rao Mandadapu]

Thanks for your time and valuable suggestions Srini!!

On 9/8/2021 3:11 PM, Srinivas Kandagatla wrote:
> On 06/09/2021 14:27, Srinivasa Rao Mandadapu wrote:
> > +#define LPASS_CDC_DMA_RX0 6
>
> You are only adding RX0, what happens to RX1.. RX7
>
> TBH, skipping other entries for ex CDC_DMA_RX will end up with sparse 
> numbering.
>
> Please add all the entries for CDC_DMA_RX and other ports as well.
>
> Like:
>
> #define LPASS_CDC_DMA_RX0    6
> #define LPASS_CDC_DMA_RX1    7
> #define LPASS_CDC_DMA_RX2    8
> #define LPASS_CDC_DMA_RX3    9
> #define LPASS_CDC_DMA_RX4    10
> #define LPASS_CDC_DMA_RX5    11
> #define LPASS_CDC_DMA_RX6    12
> #define LPASS_CDC_DMA_RX7    13
Okay. Will add and Share new patch.
> > +#define LPASS_CDC_DMA_TX3 7
> > +#define LPASS_CDC_DMA_VA0 8
> You mean VA_TX0?
Yes. Will change accordingly.
> > +#define LPASS_MAX_PORTS 9
> We really do not need this in bindings.
> You could add this is some of the driver header files instead.
Okay Will remove.
> --srini
> > +

--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.