Re: [PATCH v2] ASoC: mediatek: common: handle NULL case in suspend/resume function

From: Mark Brown
Date: Fri Sep 10 2021 - 06:24:37 EST

On Fri, Sep 10, 2021 at 05:26:13PM +0800, Trevor Wu wrote:

> When memory allocation for afe->reg_back_up fails, reg_back_up can't
> be used.
> Keep the suspend/resume flow but skip register backup when
> afe->reg_back_up is NULL, in case illegal memory access happens.

It seems like it'd be better to just allocate the buffer at probe time
and fail in case we can't get it, I'd be surprised if there's many
platforms using this hardware that don't also end up suspending and

Attachment: signature.asc
Description: PGP signature