Re: [PATCH v3 1/3] dt-bindings: aspeed: Add UART routing controller
From: Rob Herring
Date: Fri Sep 10 2021 - 11:58:00 EST
On Thu, Sep 9, 2021 at 8:38 PM ChiaWei Wang <chiawei_wang@xxxxxxxxxxxxxx> wrote:
>
> Hi Rob,
>
> > From: Rob Herring <robh@xxxxxxxxxx>
> > Sent: Thursday, September 9, 2021 8:33 PM
> >
> > On Thu, 09 Sep 2021 18:29:05 +0800, Chia-Wei Wang wrote:
> > > Add dt-bindings for Aspeed UART routing controller.
> > >
> > > Signed-off-by: Oskar Senft <osk@xxxxxxxxxx>
> > > Signed-off-by: Chia-Wei Wang <chiawei_wang@xxxxxxxxxxxxxx>
> > > ---
> > > .../bindings/soc/aspeed/uart-routing.yaml | 70
> > +++++++++++++++++++
> > > 1 file changed, 70 insertions(+)
> > > create mode 100644
> > > Documentation/devicetree/bindings/soc/aspeed/uart-routing.yaml
> > >
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m
> > dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > Documentation/devicetree/bindings/soc/aspeed/uart-routing.example.dt.yaml:
> > 0:0: /example-0/lpc@1e789000: failed to match any schema with compatible:
> > ['aspeed,ast2600-lpc-v2', 'simple-mfd', 'syscon']
>
> The "aspeed,ast2600-lpc-v2" compatible string is described in the .txt file 'aspeed-lpc.txt'.
> Do we have to firstly convert the text file into YAML one to resolve this dependency issue?
Yes. This is a significant change to the LPC block binding.
Rob