Re: [PATCH] scsi: qla2xxx: Remove redundant initialization of pointer req

[Himanshu Madhani]

> On Sep 10, 2021, at 6:46 AM, Colin King <colin.king@xxxxxxxxxxxxx> wrote:
> 
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> The pointer req is being initialized with a value that is never read, it
> is being updated later on. The assignment is redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
> drivers/scsi/qla2xxx/qla_mbx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c
> index 7811c4952035..b5e21fad9551 100644
> --- a/drivers/scsi/qla2xxx/qla_mbx.c
> +++ b/drivers/scsi/qla2xxx/qla_mbx.c
> @@ -3236,7 +3236,7 @@ qla24xx_abort_command(srb_t *sp)
> 	fc_port_t	*fcport = sp->fcport;
> 	struct scsi_qla_host *vha = fcport->vha;
> 	struct qla_hw_data *ha = vha->hw;
> -	struct req_que *req = vha->req;
> +	struct req_que *req;
> 	struct qla_qpair *qpair = sp->qpair;
> 
> 	ql_dbg(ql_dbg_mbx + ql_dbg_verbose, vha, 0x108c,
> -- 
> 2.32.0
> 

Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>

--
Himanshu Madhani	 Oracle Linux Engineering