Re: [PATCH v4 2/2] coresight: Update comments for removing cs_etm_find_snapshot()

From: Leo Yan
Date: Tue Sep 14 2021 - 06:08:58 EST


On Tue, Sep 14, 2021 at 10:27:26AM +0100, Suzuki Kuruppassery Poulose wrote:

[...]

> > diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c
> > index d23c7690f29a..ce14eb83925c 100644
> > --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c
> > +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c
> > @@ -1573,9 +1573,8 @@ tmc_update_etr_buffer(struct coresight_device *csdev,
> > /*
> > * In snapshot mode we simply increment the head by the number of byte
> > - * that were written. User space function cs_etm_find_snapshot() will
> > - * figure out how many bytes to get from the AUX buffer based on the
> > - * position of the head.
> > + * that were written. User space will figure out how many bytes to get
> > + * from the AUX buffer based on the position of the head.
> > */
> > if (etr_perf->snapshot)
> > handle->head += size;
> >
>
>
> Thanks for the revised patch, I have queued both the patches.

Cool, and thanks Suzuki!