Re: [GIT PULL] tracing: Fixes to bootconfig memory management

From: Vlastimil Babka
Date: Tue Sep 14 2021 - 18:48:02 EST


On 9/14/21 23:05, Steven Rostedt wrote:
> On Tue, 14 Sep 2021 13:48:15 -0700
> Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
>> On Tue, Sep 14, 2021 at 12:38 PM Linus Torvalds
>> <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>> >
>> > So I'll do a minimal conversion that adds "memblock_free_ptr()" and
>> > hope that people start using that. And then we can later try to move
>> > "memblock_free()" to a name that isn't so misleading.
>>
>> Commit 77e02cf57b6c ("memblock: introduce saner 'memblock_free_ptr()'
>> interface") should hopefully fix that panic that Vlastimil saw, and
>> the kernel test robot report as well.
>>
>> And it should make it easy to cleanly fix that 'copy' leak too.
>>
>
> Vlastimil,
>
> Can you confirm that Linus's changes addresses your issue?

Well, looks like I can't. Commit 77e02cf57b6cf does boot fine for me,
multiple times. But so now does the parent commit 6a4746ba06191. Looks like
the magic is gone. I'm now surprised how deterministic it was during the
bisect (most bad cases manifested on first boot, only few at second).

> Masami,
>
> Care to rebase on top of Linus's change?
>
> Thanks!
>
> -- Steve
>