Re: [PATCH v2 4/5] bootconfig: Free copied bootconfig data after boot
From: Masami Hiramatsu
Date: Tue Sep 14 2021 - 21:45:55 EST
On Tue, 14 Sep 2021 18:13:51 -0700
Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Tue, Sep 14, 2021 at 5:53 PM Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
> >
> > Free copied bootconfig data after booting kernel because that
> > data will not be used anymore.
>
> Don't do this.
>
> You have already passed in that 'copy' to the xbc code, and
> xbc_destroy_all() should just free it.
>
> Don't add new pointless variables to keep track of state that somebody
> else already keeps track of.
Ah, OK. So when I pass the copy, the ownership should be passed too.
Thank you,
>
> Linus
--
Masami Hiramatsu <mhiramat@xxxxxxxxxx>