Re: [PATCH] mm: split thp synchronously on MADV_DONTNEED

[Peter Xu]

On Thu, Nov 25, 2021 at 09:14:30AM -0800, Shakeel Butt wrote:
> On Thu, Nov 25, 2021 at 2:09 AM Peter Xu <peterx@xxxxxxxxxx> wrote:
> >
> [...]
> >
> > Hi, Shakeel,
> >
> > I saw your v2 has started to pass in zap_details, then we need know the side
> > effect on that skip-swap-entry thing because with your v2 code munmap() will
> > start to skip swap entry too (while it was not before).
> >
> > I saw that you didn't mention this in v2 patch either in commit message or
> > code, not sure whether you digged that up.  I think it needs some double check
> > (or feel free to start this digging by reviewing my small patch above :).
> >
> 
> I remember mentioning in the patch that this has dependency on your
> rfc patch. Just checked again and yeah I only mentioned in the
> 'changes since v1' section. I will add it more explicitly in the
> following versions.

Apologize for missing that section.  Yeah depending on that patch should work.

> 
> I will take a close look at your patch as well.

Thanks a lot,

-- 
Peter Xu