Re: [PATCH] dt-bindings: dma: snps,dw-axi-dmac: Document optional reset
From: Damien Le Moal
Date: Thu Nov 25 2021 - 19:05:37 EST
On 2021/11/26 0:20, Geert Uytterhoeven wrote:
> "make dtbs_check":
>
> Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> arch/riscv/boot/dts/canaan/sipeed_maix_bit.dt.yaml: dma-controller@50000000: 'resets' does not match any of the regexes: 'pinctrl-[0-9]+'
> From schema: Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
>
> The Synopsys DesignWare AXI DMA Controller on the Canaan K210 SoC
> exposes its reset signal.
>
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> index 90d9274e5464e396..06ddffaada295171 100644
> --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> @@ -53,6 +53,9 @@ properties:
> minimum: 1
> maximum: 8
>
> + resets:
> + maxItems: 1
> +
> snps,dma-masters:
> description: |
> Number of AXI masters supported by the hardware.
>
Looks good to me.
Reviewed-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
--
Damien Le Moal
Western Digital Research