Re: [PATCH] rtw89: remove unneeded conversion to bool

From: Kalle Valo
Date: Mon Nov 29 2021 - 05:43:39 EST


davidcomponentone@xxxxxxxxx wrote:

> From: Yang Guang <yang.guang5@xxxxxxxxxx>
>
> The coccinelle report
> ./drivers/net/wireless/realtek/rtw89/debug.c:817:21-26:
> WARNING: conversion to bool not needed here
> ./drivers/net/wireless/realtek/rtw89/mac.c:3698:49-54:
> WARNING: conversion to bool not needed here
> ./drivers/net/wireless/realtek/rtw89/phy.c:1770:49-54:
> WARNING: conversion to bool not needed here
> ./drivers/net/wireless/realtek/rtw89/rtw8852a.c:1056:41-46:
> WARNING: conversion to bool not needed here
>
> Relational and logical operators evaluate to bool,
> explicit conversion is overly verbose and unneeded.
>
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Yang Guang <yang.guang5@xxxxxxxxxx>

There was a similar patch already applied:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=1646ce8f83b9

Patch set to Superseded.

--
https://patchwork.kernel.org/project/linux-wireless/patch/d9492bb9bced106f20006edb49200926184c3763.1637739090.git.yang.guang5@xxxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches