Re: [PATCH] debugfs: allow to use regmap for print regs

[Li Chen]

Hi Greg,

 > >  void debugfs_print_regs32(struct seq_file *s, const struct debugfs_reg32 *regs,
 > > -              int nregs, void __iomem *base, char *prefix)
 > > +              int nregs, void __iomem *base, struct regmap *regmap,
 > > +              char *prefix)
 > 
 > This is confusing, please just provide a new function for regmap instead
 > of trying to overload this function.  You can use the same function
 > inside the debugfs core like this, but never export such a complex set
 > of parameters to actual users, that's just painful.

Thanks for your review, updated in v2.

Regards,
Li