Re: [PATCH] char: add driver for mps VR controller mp2891

[Arnd Bergmann]

On Tue, Mar 14, 2023, at 10:18, Noah (Wensheng) Wang wrote:
> Hi Arnd, Grey:
> Thanks for the review.
>
> This driver will be used by facebook. This driver provide a device node 
> for userspace to get output voltage, input voltage, input current, 
> input power, output power and temperature of mp2891 controller through 
> I2C. This driver determine what kind of value the userspace wants 
> through the mp2891_write interface and return the corresponding value 
> when the interface mp2891_read is called.
>
> Signed-off-by: Noah Wang <Noah.Wang@xxxxxxxxxxxxxxxxxxx>

Hi Noah,

>From your description, this sounds like it should be either part of the
drivers/hwmon/ framework, or drivers/iio/, but not a custom character
device.

Have you looked at those?

      Arnd