Re: [PATCH 1/2] mfd: stpmic1: fixup main control register and bits naming

From: Sean Nyekjær
Date: Tue May 16 2023 - 02:53:49 EST


Hi Lee,

> On 15 May 2023, at 14.43, Lee Jones <lee@xxxxxxxxxx> wrote:
>
> On Fri, 28 Apr 2023, Sean Nyekjaer wrote:
>
>> Fixup main control register and bits naming so the match the naming from
>> the datasheet.
>
> I'm in two minds about this.
>
> On one hand using the names from the datasheet in the right thing to
> do, however, on the other hand, the current nomenclature appears clearer.

If you like me, tries to understand what’s happening inside the PMIC. It’s really nice to have the same naming in the software as in the datasheet.

It looks like the naming was updated in the datasheet version 9.

>
>> https://www.st.com/resource/en/datasheet/stpmic1.pdf
>>
>>

[ … ]

>>
>
> --
> Lee Jones [李琼斯]


/Sean