Re: [PATCH] iommu: PGTABLE_LPAE is also for RISCV

[Alexandre Ghiti]

Hi Randy,


On 3/30/23 18:49, Randy Dunlap wrote:
> On 3/30/23 09:34, Robin Murphy wrote:
> > On 2023-03-30 07:01, Randy Dunlap wrote:
> > > On riscv64, linux-next-20233030 (and for several days earlier),
> > > there is a kconfig warning:
> > >
> > > WARNING: unmet direct dependencies detected for IOMMU_IO_PGTABLE_LPAE
> > >     Depends on [n]: IOMMU_SUPPORT [=y] && (ARM || ARM64 || COMPILE_TEST [=n]) && !GENERIC_ATOMIC64 [=n]
> > >     Selected by [y]:
> > >     - IPMMU_VMSA [=y] && IOMMU_SUPPORT [=y] && (ARCH_RENESAS [=y] || COMPILE_TEST [=n]) && !GENERIC_ATOMIC64 [=n]
> > >
> > > and build errors:
> > >
> > > riscv64-linux-ld: drivers/iommu/io-pgtable-arm.o: in function `.L140':
> > > io-pgtable-arm.c:(.init.text+0x1e8): undefined reference to `alloc_io_pgtable_ops'
> > > riscv64-linux-ld: drivers/iommu/io-pgtable-arm.o: in function `.L168':
> > > io-pgtable-arm.c:(.init.text+0xab0): undefined reference to `free_io_pgtable_ops'
> > > riscv64-linux-ld: drivers/iommu/ipmmu-vmsa.o: in function `.L140':
> > > ipmmu-vmsa.c:(.text+0xbc4): undefined reference to `free_io_pgtable_ops'
> > > riscv64-linux-ld: drivers/iommu/ipmmu-vmsa.o: in function `.L0 ':
> > > ipmmu-vmsa.c:(.text+0x145e): undefined reference to `alloc_io_pgtable_ops'
> > >
> > > Add RISCV as an allowed ARCH dependency to fix these problems.
> > >
> > > Fixes: d286a58bc8f4 ("iommu: Tidy up io-pgtable dependencies")
> > BTW that doesn't look like the right fix target - this presumably dates back as far as when ARCH_RENESAS was added to RISCV, such that it was possible to start selecting IPMMU_VMSA without COMPILE_TEST?
> OK, I can go with that. Thanks for your help.

Any updates on this fix?


Thanks,


Alex