Re: [PATCH v5 4/6] io_uring: rsrc: delegate VMA file-backed check to GUP

From: David Hildenbrand
Date: Tue May 16 2023 - 04:29:11 EST


On 14.05.23 23:26, Lorenzo Stoakes wrote:
Now that the GUP explicitly checks FOLL_LONGTERM pin_user_pages() for
broken file-backed mappings in "mm/gup: disallow FOLL_LONGTERM GUP-nonfast
writing to file-backed mappings", there is no need to explicitly check VMAs
for this condition, so simply remove this logic from io_uring altogether.


Worth adding "Note that this change will make iouring fixed buffers work on MAP_PRIVATE file mappings."

I'll run my test cases with this series and expect no surprises :)


Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

--
Thanks,

David / dhildenb