Re: [PATCH 02/13] ARM: ep93xx: fix missing-prototype warnings

[Alexander Sverdlin]

Hi Arnd!

On Tue, 2023-05-16 at 17:30 +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
> 
> ep93xx_clocksource_read() is only called from the file it is declared in,
> while ep93xx_timer_init() is declared in a header that is not included here.
> 
> arch/arm/mach-ep93xx/timer-ep93xx.c:120:13: error: no previous prototype for 'ep93xx_timer_init'
> arch/arm/mach-ep93xx/timer-ep93xx.c:63:5: error: no previous prototype for 'ep93xx_clocksource_read'
> 
> Fixes: 000bc17817bf ("ARM: ep93xx: switch to GENERIC_CLOCKEVENTS")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Acked-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxx>

> ---
>  arch/arm/mach-ep93xx/timer-ep93xx.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-ep93xx/timer-ep93xx.c b/arch/arm/mach-ep93xx/timer-ep93xx.c
> index dd4b164d1831..a9efa7bc2fa1 100644
> --- a/arch/arm/mach-ep93xx/timer-ep93xx.c
> +++ b/arch/arm/mach-ep93xx/timer-ep93xx.c
> @@ -9,6 +9,7 @@
>  #include <linux/io.h>
>  #include <asm/mach/time.h>
>  #include "soc.h"
> +#include "platform.h"
>  
>  /*************************************************************************
>   * Timer handling for EP93xx
> @@ -60,7 +61,7 @@ static u64 notrace ep93xx_read_sched_clock(void)
>         return ret;
>  }
>  
> -u64 ep93xx_clocksource_read(struct clocksource *c)
> +static u64 ep93xx_clocksource_read(struct clocksource *c)
>  {
>         u64 ret;

-- 
Alexander Sverdlin.