Re: [PATCH v2 3/3] arm64: dts: qcom: sm8550-qrd: add display and panel

[Krzysztof Kozlowski]

On 16/05/2023 18:35, Dmitry Baryshkov wrote:
> On Tue, 16 May 2023 at 18:46, Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>>
>> Enable Display Subsystem with Visionox VTDR6130 Panel (same as on
>> MTP8550).
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

...

>>
>> +       sde_dsi_active: sde-dsi-active-state {
>> +               pins = "gpio133";
>> +               function = "gpio";
>> +               drive-strength = <8>;
>> +               bias-disable;
>> +       };
>> +
>> +       sde_dsi_suspend: sde-dsi-suspend-state {
>> +               pins = "gpio133";
>> +               function = "gpio";
>> +               drive-strength = <2>;
>> +               bias-pull-down;
>> +       };
>> +
>> +       sde_te_active: sde-te-active-state {
>> +               pins = "gpio86";
>> +               function = "mdp_vsync";
>> +               drive-strength = <2>;
>> +               bias-pull-down;
>> +       };
>> +
>> +       sde_te_suspend: sde-te-suspend-state {
>> +               pins = "gpio86";
>> +               function = "mdp_vsync";
>> +               drive-strength = <2>;
>> +               bias-pull-down;
>> +       };
> 
> Do we really need the suspend states for reset and TE pins? Especially
> for the TE pin, where the only difference is the drive strength.

I don't know. For DSI there is some different, for TE looks redundant. I
admit, I copy-pasted it from MTP. :) I can fix it also there, if that's
consensus.

Best regards,
Krzysztof