Re: [PATCH] can: ctucanfd: Fix an error handling path in ctucan_probe_common()

[Christophe JAILLET]

Le 15/05/2023 à 22:51, Marc Kleine-Budde a écrit :
> On 15.05.2023 22:36:28, Christophe JAILLET wrote:
> > If register_candev() fails, a previous netif_napi_add() needs to be undone.
> > Add the missing netif_napi_del() in the error handling path.
>
> What about this path:
> free_candev(ndev) -> free_netdev() -> netif_napi_del()
>
> | https://elixir.bootlin.com/linux/v6.3.2/source/net/core/dev.c#L10714
>
> Marc

Ok, thanks for the review,

so in fact this is the netif_napi_del() call in ctucan_platform_remove() 
that can be removed instead.

Harmless, but would be more consistent.
I'll send a patch for that.

CJ