Re: [PATCH] wifi: b43: fix incorrect __packed annotation

From: Arnd Bergmann
Date: Tue May 16 2023 - 13:45:47 EST


On Tue, May 16, 2023, at 19:12, Michael Büsch wrote:
> On Tue, 16 May 2023 09:45:42 +0200
> Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
>
>> b43_iv { union {
>> __be16 d16;
>> __be32 d32;
>> - } data __packed;
>> + } __packed data;
>> } __packed;
>>
>>
>
> Oh, interesting. This has probably been there forever.
> Did you check if the b43legacy driver has the same issue?

I had not checked, but I see that it does have the same bug.

I only sent this one because the build bot (incorrectly)
blamed one of my recent patches for a regression here.
Which reminds me that I was missing:

Reported-by: kernel test robot <lkp@xxxxxxxxx>
Link: https://lore.kernel.org/oe-kbuild-all/202305160749.ay1HAoyP-lkp@xxxxxxxxx/

Should I resend this as a combined patch for both drivers?

Arnd