Re: [PATCH v1 15/15] perf vendor events intel: Add metricgroup descriptions for all models

[Liang, Kan]

On 2023-05-15 5:58 p.m., Ian Rogers wrote:
> Add metric group descriptions created by:
> https://github.com/intel/perfmon/blob/main/scripts/create_perf_json.py
> The descriptions add some additional detail in perf list.
> 
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
> ---
>  .../arch/x86/alderlake/metricgroups.json      | 122 ++++++++++++++++++
>  .../arch/x86/alderlaken/metricgroups.json     |  26 ++++
>  .../arch/x86/broadwell/metricgroups.json      | 107 +++++++++++++++
>  .../arch/x86/broadwellde/metricgroups.json    | 107 +++++++++++++++
>  .../arch/x86/broadwellx/metricgroups.json     | 107 +++++++++++++++
>  .../arch/x86/cascadelakex/metricgroups.json   | 114 ++++++++++++++++
>  .../arch/x86/haswell/metricgroups.json        | 107 +++++++++++++++
>  .../arch/x86/haswellx/metricgroups.json       | 107 +++++++++++++++
>  .../arch/x86/icelake/metricgroups.json        | 113 ++++++++++++++++
>  .../arch/x86/icelakex/metricgroups.json       | 114 ++++++++++++++++
>  .../arch/x86/ivybridge/metricgroups.json      | 107 +++++++++++++++
>  .../arch/x86/ivytown/metricgroups.json        | 107 +++++++++++++++
>  .../arch/x86/jaketown/metricgroups.json       | 100 ++++++++++++++
>  .../arch/x86/sandybridge/metricgroups.json    | 100 ++++++++++++++
>  .../arch/x86/sapphirerapids/metricgroups.json | 118 +++++++++++++++++
>  .../arch/x86/skylake/metricgroups.json        | 113 ++++++++++++++++
>  .../arch/x86/skylakex/metricgroups.json       | 114 ++++++++++++++++
>  .../arch/x86/tigerlake/metricgroups.json      | 113 ++++++++++++++++
>  18 files changed, 1896 insertions(+)
>  create mode 100644 tools/perf/pmu-events/arch/x86/alderlake/metricgroups.json
>  create mode 100644 tools/perf/pmu-events/arch/x86/alderlaken/metricgroups.json
>  create mode 100644 tools/perf/pmu-events/arch/x86/broadwell/metricgroups.json
>  create mode 100644 tools/perf/pmu-events/arch/x86/broadwellde/metricgroups.json
>  create mode 100644 tools/perf/pmu-events/arch/x86/broadwellx/metricgroups.json
>  create mode 100644 tools/perf/pmu-events/arch/x86/cascadelakex/metricgroups.json
>  create mode 100644 tools/perf/pmu-events/arch/x86/haswell/metricgroups.json
>  create mode 100644 tools/perf/pmu-events/arch/x86/haswellx/metricgroups.json
>  create mode 100644 tools/perf/pmu-events/arch/x86/icelake/metricgroups.json
>  create mode 100644 tools/perf/pmu-events/arch/x86/icelakex/metricgroups.json
>  create mode 100644 tools/perf/pmu-events/arch/x86/ivybridge/metricgroups.json
>  create mode 100644 tools/perf/pmu-events/arch/x86/ivytown/metricgroups.json
>  create mode 100644 tools/perf/pmu-events/arch/x86/jaketown/metricgroups.json
>  create mode 100644 tools/perf/pmu-events/arch/x86/sandybridge/metricgroups.json
>  create mode 100644 tools/perf/pmu-events/arch/x86/sapphirerapids/metricgroups.json
>  create mode 100644 tools/perf/pmu-events/arch/x86/skylake/metricgroups.json
>  create mode 100644 tools/perf/pmu-events/arch/x86/skylakex/metricgroups.json
>  create mode 100644 tools/perf/pmu-events/arch/x86/tigerlake/metricgroups.json
> 
> diff --git a/tools/perf/pmu-events/arch/x86/alderlake/metricgroups.json b/tools/perf/pmu-events/arch/x86/alderlake/metricgroups.json
> new file mode 100644
> index 000000000000..273ccfb0ed6f
> --- /dev/null
> +++ b/tools/perf/pmu-events/arch/x86/alderlake/metricgroups.json
> @@ -0,0 +1,122 @@
> +{
> +    "Backend": "Grouping from metrics spreadsheet",
> +    "Bad": "Grouping from metrics spreadsheet",
> +    "BadSpec": "Grouping from metrics spreadsheet",
> +    "BigFoot": "Grouping from metrics spreadsheet",
> +    "BrMispredicts": "Grouping from metrics spreadsheet",
> +    "Branches": "Grouping from metrics spreadsheet",

The description "Grouping from metrics spreadsheet" seems meaningless,
and may bring confusion information, e.g., what is metrics spreadsheet?
I think it may be better to leave it empty if we don't have a proper
description for the metricgroup.

Other descriptions look good to me.

Thanks,
Kan