Re: [PATCH v4 00/44] Fix perf on Intel hybrid CPUs

From: Arnaldo Carvalho de Melo
Date: Tue May 16 2023 - 14:19:24 EST


Em Mon, May 15, 2023 at 03:49:45PM -0700, Ian Rogers escreveu:
> On Sun, May 14, 2023 at 5:03 AM Liang, Kan <kan.liang@xxxxxxxxxxxxxxx> wrote:
> > - Segmentation fault with perf stat --topdown on ADL (hybrid) and
> > Cascade Lake.
> > It looks like a legacy issue, may not be introduced by this patch set.
> > Here is the backtrace. It looks like there is a NULL metric_group.
> >
> > (gdb) backtrace
> > #0 0x00007ffff73035d1 in __strstr_sse2_unaligned () from /lib64/libc.so.6
> > #1 0x00000000004f9019 in metricgroup__topdown_max_level_callback
> > (pm=<optimized out>, table=<optimized out>,
> > data=0x7fffffff92f4) at util/metricgroup.c:1722
> > #2 0x00000000005e8a31 in pmu_metrics_table_for_each_metric
> > (table=0xcb74d0 <pmu_events_map+368>,
> > fn=fn@entry=0x4f8ff0 <metricgroup__topdown_max_level_callback>,
> > data=data@entry=0x7fffffff92f4)
> > at pmu-events/pmu-events.c:61123
> > #3 0x00000000004fbc3b in metricgroups__topdown_max_level () at
> > util/metricgroup.c:1742
> > #4 0x000000000042c135 in add_default_attributes () at builtin-stat.c:1845
> > #5 cmd_stat (argc=0, argv=0x7fffffffe3e0) at builtin-stat.c:2446
> > #6 0x00000000004b922b in run_builtin (p=p@entry=0xd5c530
> > <commands+336>, argc=argc@entry=2,
> > argv=argv@entry=0x7fffffffe3e0) at perf.c:323
> > #7 0x000000000040e373 in handle_internal_command (argv=0x7fffffffe3e0,
> > argc=2) at perf.c:377
> > #8 run_argv (argv=<synthetic pointer>, argcp=<synthetic pointer>) at
> > perf.c:421
> > #9 main (argc=2, argv=0x7fffffffe3e0) at perf.c:537
> > (gdb)
>
> Thanks, there's a 1-liner for the segv:
> https://lore.kernel.org/lkml/20230515224530.671331-1-irogers@xxxxxxxxxx/
> Arnaldo, can we make sure this goes toward the next 6.4 release candidate?

Sure.

- Arnaldo