Re: [PATCH net v2 2/4] Documentation: net/mlx5: Use bullet and definition lists for vnic counters description

From: Daniel.Machon
Date: Tue May 16 2023 - 15:18:28 EST


> Description of the vnic counters:
> -total_q_under_processor_handle: number of queues in an error state due to
> -an async error or errored command.
> -send_queue_priority_update_flow: number of QP/SQ priority/SL update
> -events.
> -cq_overrun: number of times CQ entered an error state due to an
> -overflow.
> -async_eq_overrun: number of times an EQ mapped to async events was
> -overrun.
> -comp_eq_overrun: number of times an EQ mapped to completion events was
> -overrun.
> -quota_exceeded_command: number of commands issued and failed due to quota
> -exceeded.
> -invalid_command: number of commands issued and failed dues to any reason
> -other than quota exceeded.
> -nic_receive_steering_discard: number of packets that completed RX flow
> -steering but were discarded due to a mismatch in flow table.
> +
> +- total_q_under_processor_handle
> + number of queues in an error state due to
> + an async error or errored command.
> +- send_queue_priority_update_flow
> + number of QP/SQ priority/SL update events.
> +- cq_overrun
> + number of times CQ entered an error state due to an overflow.
> +- async_eq_overrun
> + number of times an EQ mapped to async events was overrun.
> + comp_eq_overrun number of times an EQ mapped to completion events was
> + overrun.
> +- quota_exceeded_command
> + number of commands issued and failed due to quota exceeded.
> +- invalid_command
> + number of commands issued and failed dues to any reason other than quota
> + exceeded.

Hi Bagas,

nit: I think 'dues' should be 'due' here. Might as well get that in
when touching the code anyway.

Other than that:

Reviewed-by: Daniel Machon <daniel.machon@xxxxxxxxxxxxx>

> +- nic_receive_steering_discard
> + number of packets that completed RX flow
> + steering but were discarded due to a mismatch in flow table.