Re: [PATCH] accel/qaic: silence some uninitialized variable warnings

[Jeffrey Hugo]

On 5/10/2023 10:48 AM, Dan Carpenter wrote:
> On Wed, May 10, 2023 at 08:57:03AM -0600, Jeffrey Hugo wrote:
> > On 5/3/2023 4:41 AM, Dan Carpenter wrote:
> > > Smatch complains that these are not initialized if get_cntl_version()
> > > fails but we still print them in the debug message.  Not the end of
> > > the world, but true enough.  Let's just initialize them to a dummy value
> > > to make the checker happy.
> > >
> > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> >
> > Thanks for the cleanup.
> >
> > Reviewed-by: Jeffrey Hugo <quic_jhugo@xxxxxxxxxxx>
> >
> > Could use a fixes tag
>
> The fixes tag thing could have gone either way.  It's really minor.
>
> > and also I'd prefer to maintain the style of sorting
> > the variable declaration lines by line length.  Given the minor nature of
> > these nits, I plan to address them.
>
> Thanks!

Pushed to drm-misc-fixes

-Jeff