Re: [PATCH 1/2] dt-bindings: mfd: gateworks-gsc: remove unnecessary fan-controller nodes

From: Conor Dooley
Date: Tue May 16 2023 - 17:20:16 EST


Hey Tim,

On Tue, May 16, 2023 at 08:33:13AM -0700, Tim Harvey wrote:
> Remove the unnecessary #address-cells and #size-cells nodes from
> the fan-controller.

It'd be nice to mentioned _why_ they are redundant, since the diff
doesn't contain that context.
Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Thanks,
Conor.

>
> Signed-off-by: Tim Harvey <tharvey@xxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/mfd/gateworks-gsc.yaml | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
> index acb9c54942d9..dc379f3ebf24 100644
> --- a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
> +++ b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
> @@ -122,12 +122,6 @@ patternProperties:
> compatible:
> const: gw,gsc-fan
>
> - "#address-cells":
> - const: 1
> -
> - "#size-cells":
> - const: 0
> -
> reg:
> description: The fan controller base address
> maxItems: 1
> @@ -135,8 +129,6 @@ patternProperties:
> required:
> - compatible
> - reg
> - - "#address-cells"
> - - "#size-cells"
>
> required:
> - compatible
> @@ -194,8 +186,6 @@ examples:
> };
>
> fan-controller@2c {
> - #address-cells = <1>;
> - #size-cells = <0>;
> compatible = "gw,gsc-fan";
> reg = <0x2c>;
> };
> --
> 2.25.1
>

Attachment: signature.asc
Description: PGP signature