Re: [PATCH v8 05/14] mfd: rk808: split into core and i2c

From: Marek Szyprowski
Date: Tue May 16 2023 - 17:27:10 EST


Hi,

On 04.05.2023 19:36, Sebastian Reichel wrote:
> Split rk808 into a core and an i2c part in preparation for
> SPI support.
>
> Acked-for-MFD-by: Lee Jones <lee@xxxxxxxxxx>
> Acked-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> # for RTC
> Tested-by: Diederik de Haas <didi.debian@xxxxxxxxx> # Rock64, Quartz64 Model A + B
> Tested-by: Vincent Legoll <vincent.legoll@xxxxxxxxx> # Pine64 QuartzPro64
> Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>

This patch landed in today's linux-next as commit c20e8c5b1203 ("mfd:
rk808: Split into core and i2c"). Unfortunately some boards (for example
Hardkernel's Odroid-M1) stopped to boot after this change. This is
caused by the lack of updating the related defconfigs. Could you please
add a patch that updates the MFD_RK808 entries to MFD_RK8XX_I2C in the
following files:

$ git grep MFD_RK808
arch/arm/configs/multi_v7_defconfig:CONFIG_MFD_RK808=y
arch/arm64/configs/defconfig:CONFIG_MFD_RK808=y


> ---
> drivers/clk/Kconfig | 2 +-
> drivers/input/misc/Kconfig | 2 +-
> drivers/mfd/Kconfig | 7 +-
> drivers/mfd/Makefile | 3 +-
> drivers/mfd/{rk808.c => rk8xx-core.c} | 209 +++++---------------------
> drivers/mfd/rk8xx-i2c.c | 200 ++++++++++++++++++++++++
> drivers/pinctrl/Kconfig | 2 +-
> drivers/power/supply/Kconfig | 2 +-
> drivers/regulator/Kconfig | 2 +-
> drivers/rtc/Kconfig | 2 +-
> include/linux/mfd/rk808.h | 6 +
> sound/soc/codecs/Kconfig | 2 +-
> 12 files changed, 256 insertions(+), 183 deletions(-)
> rename drivers/mfd/{rk808.c => rk8xx-core.c} (76%)
> create mode 100644 drivers/mfd/rk8xx-i2c.c
>
> ...

Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland