Re: [PATCH v3 0/6] sysctl: Remove register_sysctl_table from parport

From: Luis Chamberlain
Date: Tue May 16 2023 - 19:07:41 EST


On Tue, May 16, 2023 at 06:28:57PM +0200, Joel Granados wrote:
> This is part of the general push to deprecate register_sysctl_paths and
> register_sysctl_table. Parport driver uses the "CHILD" pointer
> in the ctl_table structure to create its directory structure. We move to
> the newer register_sysctl call and remove the pointer madness.
>
> I have separated the parport into 5 patches to clarify the different
> changes needed for the 3 calls to register_sysctl_paths. I can squash
> them together if need be.
>
> We no longer export the register_sysctl_table call as parport was the
> last user from outside proc_sysctl.c. Also modified documentation slightly
> so register_sysctl_table is no longer mentioned.
>
> V2:
> * Added a return error value when register fails
> * Made sure to free the memory on error when calling parport_proc_register
> * Added a bloat-o-meter output to measure bloat
> * Replaced kmalloc with kzalloc
> * Added comments about testing
> * Improved readability when using snprintf

Thanks, applied and pushed!

Luis