Re: [PATCH 05/13] ARM: imx: remove unused mx25_revision()

From: Fabio Estevam
Date: Tue May 16 2023 - 19:34:17 EST


Hi Arnd,

On Tue, May 16, 2023 at 12:32 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
>
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> This function has no prototype and no callers:
>
> arm/mach-imx/cpu-imx25.c:43:5: error: no previous prototype for 'mx25_revision' [-Werror=missing-prototypes]
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Martin Kaiser sent a patch adding a user for this function:

https://lore.kernel.org/linux-arm-kernel/20220815190748.102664-2-martin@xxxxxxxxx/

It would be better to apply Martin's patch instead of removing mx25_revision().

Thanks