Re: [PATCH v3 2/4] dt-bindings: thermal: tsens: Add ipq9574 compatible
From: Krzysztof Kozlowski
Date: Wed May 17 2023 - 03:00:58 EST
On 17/05/2023 07:57, Varadarajan Narayanan wrote:
> Part-1 is adding the 'const' entries at the beginning i.e.
>
> + - const: qcom,tsens-v0_1
> + - const: qcom,tsens-v1
> + - const: qcom,tsens-v2
> + - const: qcom,ipq8074-tsens
>
> Part-2 is changing from one valid syntax to another i.e.
>
> + items:
> + - enum:
> + - qcom,ipq9574-tsens
> + - const: qcom,ipq8074-tsens
>
> Without both of the above changes, either or both of dtbs_check
> & dt_binding_check fails. So, it is not possible to just add the
> "valid hunk" (part-2) alone.
Of course it is. All schema files work like that...
>
> If having both part-1 and part-2 in the same patch is not
> acceptable, shall I split them into two patches? Please let me know.
No, hunk one is not justified.
Best regards,
Krzysztof