Re: [EXTERNAL] [RFC PATCH V6 13/14] x86/hyperv: Add smp support for sev-snp guest

[Tianyu Lan]

On 5/16/2023 1:16 PM, Saurabh Singh Sengar wrote:
> > +		(struct hv_enable_vp_vtl *)ap_start_input_arg;
> > +	memset(start_vp_input, 0, sizeof(*start_vp_input));
> > +	start_vp_input->partition_id = -1;
> > +	start_vp_input->vp_index = cpu;
> > +	start_vp_input->target_vtl.target_vtl = ms_hyperv.vtl;
> > +	*(u64 *)&start_vp_input->vp_context = __pa(vmsa) | 1;
> > +
> > +	do {
> > +		ret = hv_do_hypercall(HVCALL_START_VP,
> > +				      start_vp_input, NULL);
> > +	} while (hv_result(ret) == HV_STATUS_TIME_OUT && retry--);
> can we restore local_irq here ?
>
> > +
> > +	if (!hv_result_success(ret)) {
> > +		pr_err("HvCallStartVirtualProcessor failed: %llx\n", ret);
> > +		goto done;
> No need of goto here.

Nice catch. The goto label should be removed here. Will update in the 
next version.