[PATCH] ipmi_watchdog: Fix read syscall not responding to signals during sleep

From: Zhen Ni
Date: Wed May 17 2023 - 05:33:40 EST


Read syscall cannot response to sigals when data_to_read remains at 0
and the while loop cannot break. Fix it.

Signed-off-by: Zhen Ni <zhen.ni@xxxxxxxxxxxx>
---
drivers/char/ipmi/ipmi_watchdog.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_watchdog.c b/drivers/char/ipmi/ipmi_watchdog.c
index 0d4a8dcacfd4..e7eb3e140444 100644
--- a/drivers/char/ipmi/ipmi_watchdog.c
+++ b/drivers/char/ipmi/ipmi_watchdog.c
@@ -807,13 +807,12 @@ static ssize_t ipmi_read(struct file *file,
spin_unlock_irq(&ipmi_read_lock);
schedule();
spin_lock_irq(&ipmi_read_lock);
+ if (signal_pending(current)) {
+ rv = -ERESTARTSYS;
+ break;
+ }
}
remove_wait_queue(&read_q, &wait);
-
- if (signal_pending(current)) {
- rv = -ERESTARTSYS;
- goto out;
- }
}
data_to_read = 0;

--
2.20.1