Re: [PATCH v2 7/9] wifi: ath11k: Use RMW accessors for changing LNKCTL
From: Kalle Valo
Date: Wed May 17 2023 - 07:05:27 EST
Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> writes:
> Don't assume that only the driver would be accessing LNKCTL. ASPM
> policy changes can trigger write to LNKCTL outside of driver's control.
>
> Use RMW capability accessors which do proper locking to avoid losing
> concurrent updates to the register value. On restore, clear the ASPMC
> field properly.
>
> Fixes: e9603f4bdcc0 ("ath11k: pci: disable ASPM L0sLs before downloading firmware")
> Suggested-by: Lukas Wunner <lukas@xxxxxxxxx>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
Acked-by: Kalle Valo <kvalo@xxxxxxxxxx>
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches