Re: [PATCH 3/3] arm64: dts: qcom: sm8550: Add missing RPMhPD OPP levels

[Konrad Dybcio]

On 17.05.2023 15:25, Konrad Dybcio wrote:
> 
> 
> On 17.05.2023 15:25, Dmitry Baryshkov wrote:
>> On Wed, 17 May 2023 at 16:20, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote:
>>>
>>> We need more granularity for things like the GPU. Add the missing levels.
>>>
>>> This unfortunately requires some re-indexing, resulting in an ugly diff.
>>>
>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
>>> ---
>>>  arch/arm64/boot/dts/qcom/sm8550.dtsi | 36 ++++++++++++++++++++++++++++--------
>>>  1 file changed, 28 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
>>> index 6e9bad8f6f33..0c987dd4e4e5 100644
>>> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
>>> @@ -3616,35 +3616,55 @@ rpmhpd_opp_min_svs: opp2 {
>>>                                                 opp-level = <RPMH_REGULATOR_LEVEL_MIN_SVS>;
>>>                                         };
>>>
>>> -                                       rpmhpd_opp_low_svs: opp3 {
>>> +                                       rpmhpd_opp_lov_svs_d2: opp3 {
>>> +                                               opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS_D2>;
>>> +                                       };
>>>
>>
>> Maybe we should stop using the indices for OPP entries and switch to
>> encoding levels instead?
> I think we should just retire this and register a hardcoded OPP table
> in the .c driver.
But then we don't have any required-opps to reference... yeah the nodes
should probably be renamed to opp-<levelvalue>

Konrad
> 
> Konrad
>>