Re: [PATCH v13 1/1] media: i2c: imx334: update pixel, hblank and link frequency

From: Sakari Ailus
Date: Wed May 17 2023 - 10:04:16 EST


On Fri, Apr 14, 2023 at 06:03:11PM +0530, shravan kumar wrote:
> From: Shravan Chippa <shravan.chippa@xxxxxxxxxxxxx>
>
> Update pixel_rate and link frequency for 1920x1080@30
> while changing mode.
>
> Update vblank value while changing mode
>
> Add support to handle multiple link frequencies.
>
> Add dummy ctrl cases for pixel_rate and link frequency
> to avoid error while changing the modes dynamically.
>
> Update default link frequency from device tree max link
> frequency value.
>
> Update init_cfg() function to update the link frequency
> menu_skip_mask value.
>
> Suggested-by: Sakari Ailus <sakari.ailus@xxxxxx>
> Signed-off-by: Shravan Chippa <shravan.chippa@xxxxxxxxxxxxx>

Applied with the following diff:

diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c
index d4c9986aee597..93fc1716e00a1 100644
--- a/drivers/media/i2c/imx334.c
+++ b/drivers/media/i2c/imx334.c
@@ -118,6 +118,7 @@ struct imx334_mode {
* @vblank: Vertical blanking in lines
* @cur_mode: Pointer to current selected sensor mode
* @mutex: Mutex for serializing sensor controls
+ * @menu_skip_mask: Menu skip mask for link_freq_ctrl
* @cur_code: current selected format code
* @streaming: Flag indicating streaming state
*/


--
Sakari Ailus