Re: [PATCH 2/2] ALSA: oss: avoid missing-prototype warnings

From: Takashi Iwai
Date: Wed May 17 2023 - 10:57:30 EST


On Tue, 16 May 2023 21:50:42 +0200,
Arnd Bergmann wrote:
>
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> Two functions are defined and used in pcm_oss.c but also optionally
> used from io.c, with an optional prototype. If CONFIG_SND_PCM_OSS_PLUGINS
> is disabled, this causes a warning as the functions are not static
> and have no prototype:
>
> sound/core/oss/pcm_oss.c:1235:19: error: no previous prototype for 'snd_pcm_oss_write3' [-Werror=missing-prototypes]
> sound/core/oss/pcm_oss.c:1266:19: error: no previous prototype for 'snd_pcm_oss_read3' [-Werror=missing-prototypes]
>
> Avoid this by making the prototypes unconditional.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Thanks, applied now.


Takashi