Re: [PATCH 3/5] s390/uvdevice: Add 'List Secrets' UVC

[Steffen Eiden]

Thanks for your review.


On 5/17/23 18:03, Claudio Imbrenda wrote:
> > static int uvio_list_secrets(struct uvio_ioctl_cb *uv_ioctl)
> > +{
> > +	void __user *user_buf_arg = (void __user *)uv_ioctl->argument_addr;
> > +	struct uv_cb_guest_addr uvcb = {
> > +		.header.len = sizeof(uvcb),
> > +		.header.cmd = UVC_CMD_LIST_SECRETS,
> > +	};
> > +	void *secrets = NULL;
> > +	int ret;
> > +
> > +	if (uv_ioctl->argument_len != UVIO_LIST_SECRETS_LEN)
> > +		return -EINVAL;
> > +
> > +	secrets = kvzalloc(uv_ioctl->argument_len, GFP_KERNEL);
> > +	if (!secrets)
> > +		return -ENOMEM;
> > +
> > +	uvcb.addr = (u64)secrets;
> I think you need virt_to_phys()
The UV expects a virtual address here.

> > +	uv_call_sched(0, (u64)&uvcb);
> > +	uv_ioctl->uv_rc = uvcb.header.rc;
> > +	uv_ioctl->uv_rrc = uvcb.header.rrc;
> > +
> > +	if (copy_to_user(user_buf_arg, secrets, uv_ioctl->argument_len))
> > +		ret = -EFAULT;
> > +	else
> > +		ret = 0;
> > +
> > +	kvfree(secrets);
> > +	return ret;
> > +}

Steffen