Re: [PATCH] selftests: fib_tests: mute cleanup error message

From: Po-Hsu Lin
Date: Wed May 17 2023 - 23:22:59 EST


On Wed, May 17, 2023 at 2:00 PM Ido Schimmel <idosch@xxxxxxxxxx> wrote:
>
> On Wed, May 17, 2023 at 12:11:19PM +0800, Po-Hsu Lin wrote:
> > In the end of the test, there will be an error message induced by the
> > `ip netns del ns1` command in cleanup()
> >
> > Tests passed: 201
> > Tests failed: 0
> > Cannot remove namespace file "/run/netns/ns1": No such file or directory
> >
> > Redirect the error message to /dev/null to mute it.
> >
> > Fixes: a0e11da78f48 ("fib_tests: Add tests for metrics on routes")
>
> I don't think this tag is correct. More likely that this is caused by
> commit b60417a9f2b8 ("selftest: fib_tests: Always cleanup before exit").
>
> You can even reproduce it with '-h':
>
> # ./fib_tests.sh -h
> usage: fib_tests.sh OPTS
> [...]
> Cannot remove namespace file "/var/run/netns/ns1": No such file or directory
>
> Reverting the commit I mentioned makes it go away.
>
> Also, please use "PATCH net" prefix:
> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#tl-dr

Thank you!
I will submit V2 for this.