Re: [PATCH 1/3] MAINTAINERS: Add additional reviewers for CXL

From: Ira Weiny
Date: Thu May 18 2023 - 10:42:35 EST


Jonathan Cameron wrote:
> On Wed, 17 May 2023 14:28:10 -0700
> Ira Weiny <ira.weiny@xxxxxxxxx> wrote:
>
> > To get better coverage add Dave Jiang and Jonathan Cameron as reviewers.
> >
> > Cc: Dave Jiang <dave.jiang@xxxxxxxxx>
> > Cc: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> > Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx>
>
> Acked-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
>
> One comment inline though on capitalization.
>
> Thanks,
>
> Jonathan
>
> > ---
> > MAINTAINERS | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 90abe83c02f3..6f8568ec2731 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -5169,6 +5169,8 @@ M: Vishal Verma <vishal.l.verma@xxxxxxxxx>
> > M: Ira Weiny <ira.weiny@xxxxxxxxx>
> > M: Ben Widawsky <bwidawsk@xxxxxxxxxx>
> > M: Dan Williams <dan.j.williams@xxxxxxxxx>
> > +R: Dave Jiang <dave.jiang@xxxxxxxxx>
> > +R: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
>
> For consistency go with <jonathan.cameron@xxxxxxxxxx>
> which is what I'm using elsewhere in maintainers and
> matches other lower case entries here.

NP on this change. However, FYI b4 picks up your email capitalized a lot.
For example when you ack/review as you did above.

Ira

>
>
>
> > L: linux-cxl@xxxxxxxxxxxxxxx
> > S: Maintained
> > F: drivers/cxl/
> >
>