Re: [PATCH AUTOSEL 6.3 6/7] powerpc/fsl_uli1575: Allow to disable FSL_ULI1575 support

From: Sasha Levin
Date: Thu May 18 2023 - 13:48:43 EST


On Tue, May 09, 2023 at 09:18:35AM +0200, Pali Rohár wrote:
On Tuesday 09 May 2023 17:14:48 Michael Ellerman wrote:
Randy Dunlap <rdunlap@xxxxxxxxxxxxx> writes:
> Hi--
>
> Just a heads up. This patch can cause build errors.
> I sent a patch for these on 2023-APR-28:
> https://lore.kernel.org/linuxppc-dev/20230429043519.19807-1-rdunlap@xxxxxxxxxxxxx/
>
> Michael, I think this is your area if I'm not mistaken.

Yes. The fix is in my fixes branch as:
536d948a8dee ("powerpc/fsl_uli1575: fix kconfig warnings and build errors")

But I don't think this commit (22fdf79171e8) really warrants going to
stable, it's a nice-to-have but doesn't fix any pressing bugs.

Exactly. And also this patch alone without 1/8 would not work as in 1/8
https://lore.kernel.org/all/20230409000812.18904-2-pali@xxxxxxxxxx/ was
added static inline variant of function which is used when ULI is
disabled.

I'll drop it, thanks!

--
Thanks,
Sasha