Re: [Intel-wired-lan] [PATCH net-next 07/11] net: page_pool: add DMA-sync-for-CPU inline helpers
From: Jakub Kicinski
Date: Thu May 18 2023 - 16:36:35 EST
On Thu, 18 May 2023 17:41:52 +0200 Alexander Lobakin wrote:
> > Or maybe we can do both? I think that separating types, defines and
> > simple wrappers from helpers should be considered good code hygiene.
>
> I'll definitely take a look, I also like the idea of minimalistic and
> lightweight headers.
> page_pool.h and page_pool_drv.h? :D
What I've been doing lately is split like this:
include/net/something.h (simply includes all other headers)
include/net/something/types.h (structs, defines, enums)
include/net/something/functions.h (inlines and function declarations)
If that's reasonable -- we should put the helpers under
include/net/page_pool/functions.h ?