RE: [PATCH net-next] net: fec: turn on XDP features

[Wei Fang]

> -----Original Message-----
> From: Lorenzo Bianconi <lorenzo.bianconi@xxxxxxxxxx>
> Sent: 2023年5月19日 4:16
> To: Simon Horman <simon.horman@xxxxxxxxxxxx>
> Cc: Wei Fang <wei.fang@xxxxxxx>; davem@xxxxxxxxxxxxx;
> edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx;
> ast@xxxxxxxxxx; daniel@xxxxxxxxxxxxx; hawk@xxxxxxxxxx;
> john.fastabend@xxxxxxxxx; Shenwei Wang <shenwei.wang@xxxxxxx>; Clark
> Wang <xiaoning.wang@xxxxxxx>; netdev@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; bpf@xxxxxxxxxxxxxxx; dl-linux-imx
> <linux-imx@xxxxxxx>; Lorenzo Bianconi <lorenzo@xxxxxxxxxx>
> Subject: Re: [PATCH net-next] net: fec: turn on XDP features
> 
> > +Lorenzo
> >
> > On Thu, May 18, 2023 at 10:32:36PM +0800, wei.fang@xxxxxxx wrote:
> > > From: Wei Fang <wei.fang@xxxxxxx>
> > >
> > > The XDP features are supported since the commit 66c0e13ad236
> > > ("drivers: net: turn on XDP features"). Currently, the fec driver
> > > supports NETDEV_XDP_ACT_BASIC, NETDEV_XDP_ACT_REDIRECT and
> > > NETDEV_XDP_ACT_NDO_XMIT. So turn on these XDP features for fec
> > > driver.
> > >
> > > Signed-off-by: Wei Fang <wei.fang@xxxxxxx>
> > > ---
> > >  drivers/net/ethernet/freescale/fec_main.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/net/ethernet/freescale/fec_main.c
> > > b/drivers/net/ethernet/freescale/fec_main.c
> > > index cd215ab20ff9..577affda6efa 100644
> > > --- a/drivers/net/ethernet/freescale/fec_main.c
> > > +++ b/drivers/net/ethernet/freescale/fec_main.c
> > > @@ -4030,6 +4030,8 @@ static int fec_enet_init(struct net_device *ndev)
> > >  	}
> > >
> > >  	ndev->hw_features = ndev->features;
> > > +	ndev->xdp_features = NETDEV_XDP_ACT_BASIC |
> NETDEV_XDP_ACT_REDIRECT |
> > > +			     NETDEV_XDP_ACT_NDO_XMIT;
> 
> should we check FEC_QUIRK_SWAP_FRAME here? something like:
> 
> 	if (!(fep->quirks & FEC_QUIRK_SWAP_FRAME)
> 		ndev->xdp_features = NETDEV_XDP_ACT_BASIC |
> 				     NETDEV_XDP_ACT_REDIRECT |
> 				     NETDEV_XDP_ACT_NDO_XMIT;
> 
> 
It's really a good suggestion, thank you so much!

> > >
> > >  	fec_restart(ndev);
> > >
> > > --
> > > 2.25.1
> > >
> > >
> >