Re: [PATCH v7 1/5] block: Don't invalidate pagecache for invalid falloc modes

From: Christoph Hellwig
Date: Fri May 19 2023 - 00:09:41 EST


On Thu, May 18, 2023 at 03:33:22PM -0700, Sarthak Kukreti wrote:
> Only call truncate_bdev_range() if the fallocate mode is
> supported. This fixes a bug where data in the pagecache
> could be invalidated if the fallocate() was called on the
> block device with an invalid mode.
>
> Fixes: 25f4c41415e5 ("block: implement (some of) fallocate for block devices")
> Cc: stable@xxxxxxxxxxxxxxx
> Reported-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> Signed-off-by: Sarthak Kukreti <sarthakkukreti@xxxxxxxxxxxx>

Looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>