Re: [PATCH 0/2] tools/nolibc: riscv: Fix up compile error for rv32

From: Thomas Weißschuh
Date: Fri May 19 2023 - 06:11:10 EST


Hi Willy,

On 2023-05-19 11:40:30+0200, Willy Tarreau wrote:
> Hi Zhangjin,
>
> On Fri, May 19, 2023 at 01:00:18AM +0800, Zhangjin Wu wrote:
> > Hi, Willy
> >
> > nolibc for riscv is only tested for rv64 currently (see
> > tools/testing/selftests/nolibc/Makefile), this patchset tries to let it
> > compile for rv32, but still not pass the nolibc selftest:
> >
> > * The first patch uses lw/sw instead of ld/sd for rv32 and verse-vice for rv64
> > * This patch may conflict with the stackprotector patch [1], because
> > both of them changed the _start assembly in arch-riscv.h
>
> That's quite embarrassing, I'm having to trace of that series here. Now
> I can find it in my LKML archives, but I don't have the direct message and
> didn't spot the other ones. I'll have to investigate, thanks for notifying
> me! I'm CCing Thomas, I will check with him how to best merge the two.

I think the conflict should be trivial to fix.

I can also resend my series or just the single riscv patch.

<snip>

Thomas