Re: [PATCH] dmaengine: ste_dma40: use proper format string for resource_size_t

From: Vinod Koul
Date: Fri May 19 2023 - 06:47:06 EST


On 18-05-23, 13:59, Arnd Bergmann wrote:
> On Thu, May 18, 2023, at 13:29, Vinod Koul wrote:
> > On 17-05-23, 22:19, Arnd Bergmann wrote:
> >> From: Arnd Bergmann <arnd@xxxxxxxx>
> >>
> >> When LPAE is set, both the dma_addr_t and resource_size_t become 64 bit
> >> wide, causing a warning about the format string:
> >>
> >> drivers/dma/ste_dma40.c: In function 'd40_probe':
> >> drivers/dma/ste_dma40.c:3539:23: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' {aka 'long long unsigned int'} [-Werror=format=]
> >> 3539 | dev_info(dev, "found LCPA SRAM at 0x%08x, size 0x%08x\n",
> >>
> >> Change both to the special %pap and %pap helpers for these types.
> >
> > Already posted [1] and applied now
> >
> > [1]: https://lore.kernel.org/r/20230517064434.141091-1-vkoul@xxxxxxxxxx
>
> I think yours is wrong: you use %pR with a resource_size_t, but it
> expects a "struct resource instead".

Right, i indeed looked up wrong format

--
~Vinod